[Ready for EngSys Review] ESRP Publishing #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
github-project-automation
bot
added this to
Azure SDK for Key Vault and Azure Identity SDK Improvements
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
danieljurek
commented
Oct 14, 2025
danieljurek
commented
Oct 14, 2025
…s in output folders
danieljurek
requested review from
a team,
LarryOsterman,
chlowell,
j7nw4r,
jalauzon-msft,
ronniegeraghty and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new ESRP-based publishing strategy for Rust crates that uses cargo publish --dry-run to package crates and publishes them through ESRP instead of directly to crates.io. The changes include:
- Replacing direct crates.io publishing with ESRP release process
- Switching from
safeNametoreleaseInBatchparameters for artifact configuration - Refactoring
Pack-Crates.ps1to usecargo publish --dry-runinstead of custom vendoring - Updating package info extraction to work with
.cratefiles instead ofCargo.toml
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/ci.yml | Adds release parameters for storage crates and updates artifact configuration with releaseInBatch |
| sdk/servicebus/ci.yml | Adds release parameter for servicebus crate and updates artifact configuration |
| sdk/keyvault/ci.yml | Adds release parameters for keyvault crates and updates artifact configuration |
| sdk/identity/ci.yml | Adds release parameter for identity crate and updates artifact configuration |
| sdk/eventhubs/ci.yml | Adds release parameters for eventhubs crates and updates artifact configuration |
| sdk/cosmos/ci.yml | Adds release parameter for cosmos crate and updates artifact configuration |
| sdk/core/ci.yml | Adds release parameters for core crates with inconsistent naming and updates artifact configuration |
| sdk/canary/ci.yml | Adds release parameters for canary crates and updates artifact configuration |
| eng/scripts/Pack-Crates.ps1 | Refactors crate packing to use cargo publish --dry-run and removes custom vendoring logic |
| eng/scripts/Language-Settings.ps1 | Updates to extract package info from .crate files instead of Cargo.toml |
| eng/pipelines/templates/stages/archetype-sdk-client.yml | Filters artifacts based on releaseInBatch parameter |
| eng/pipelines/templates/stages/archetype-rust-release.yml | Replaces direct crates.io publishing with ESRP release process and removes yank job |
| eng/pipelines/templates/jobs/pack.yml | Adds logic to configure crate packing based on release parameters |
weshaggard
reviewed
Oct 17, 2025
weshaggard
reviewed
Oct 17, 2025
weshaggard
reviewed
Oct 17, 2025
…he literal "$(ArtifactName)"
heaths
approved these changes
Oct 17, 2025
weshaggard
reviewed
Oct 17, 2025
weshaggard
reviewed
Oct 17, 2025
hallipr
reviewed
Oct 17, 2025
weshaggard
approved these changes
Oct 17, 2025
weshaggard
reviewed
Oct 20, 2025
weshaggard
approved these changes
Oct 20, 2025
github-project-automation
bot
moved this from 🤔 Triage
to 🔬 Dev in PR
in Azure SDK EngSys 🍔🌭
github-project-automation
bot
moved this from Untriaged
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
SERVICE OWNERS: no need to review this PR. I'm making engsys changes to ci.yml files.
Really fixes #3035
[keeping as draft to avoid notifying everyone]
A new release crate-packing strategy for Rust which uses
cargo publish --dry-runto produce the crates:This uses existing tooling to do the build with no vendoring or separate packing. Release order sorting can be read from the tool output and doesn't need to be computed from metadata.
cargo publishalso verifies that dependencies defined in the package'sCargo.tomlare published and fails if they are not published.This also supports the current Pre-GA approach of not incrementing core's versions after release as the workspace dependency includes
For example:
If a package depends on
[email protected]and there is no[email protected]published on crates.io, the command will fail. It's possible to "atomically" generate packages for releases with unreleased dependencies if those dependencies are included in the package command (e.g.storage_blobsdepending onstorage_common)Formatting:
Formatting attempts to match reasonable outputs. Redirecting stderr from
cargo publishwould normally result in red console text. Thecargo publishcommand is also grouped: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5461494&view=logs&j=b766ebde-1fdb-5f11-1350-46ddc53b23cf&t=7ef29fa0-f532-5653-3473-16dc04608431&l=104Tests: